Re: [OpenVerse] Bug in user cancel of a room download

[Cruise <cruise@openverse.org>]

I would like to suggest another idea.

I've implemented Kaos's code in the EndDcc function but I've also added some
code which removes the cancel download button if the download type is of ROOM.
(so basically, currently, kaos's code would never get executed).

I've commented these parts of the code with #ISSUE 01 and one of the two
portions will be removed when the issue is resolved.

I feel that a room download should not be cancelable. The room image is very
important I think.

What do y'all think? 

(CVS code coming soon, minutes from now)


On Fri, 14 Jan 2000, you wrote:
> It looks like the new code prevents you from changing rooms if you have a
> room download in progress.  But, if you click on that download and then
> click "End Download", you can no longer change rooms at all.  The following
> patch fixes this by changing "proc endDCC".  It could probably be done
> better; I haven't checked to see if a failed room download causes the same
> condition.
> 
> cd /usr/lib;patch -p0 <<EOF
> *** OpenVerse/lib/IOFuncs.tcl.org       Fri Jan 14 11:34:00 2000
> --- OpenVerse/lib/IOFuncs.tcl   Fri Jan 14 11:34:52 2000
> ***************
> *** 1147,1150 ****
> --- 1147,1153 ----
>                 catch {close $MV(DCC.$index.server)}
>         }
> +       if {$type == "Cancel" && $MV(DCC.$index.type) == "ROOM"} {
> +               set MV(downloadingroom) 0
> +       }
>         if {$type == "Get"} {
>                 switch -exact -- $MV(DCC.$index.type) {
> EOF
> 
> ----------------------------------------------------------
> To unsubscribe to the OpenVerse mailing list send a message to
> openverse-request with the following word in the BODY of the message.
> UNSUBSCRIBE
> If you need assistance from a human, email cruise@openverse.org
> ----------------------------------------------------------
-- 
Cruise - 
OpenVerse Visual Chat - http://openverse.org/
----------------------------------------------------------
To unsubscribe to the OpenVerse mailing list send a message to
openverse-request with the following word in the BODY of the message.
UNSUBSCRIBE
If you need assistance from a human, email cruise@openverse.org
----------------------------------------------------------